[PATCH] D79428: [WebAssembly] Added Debug Fixup pass

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 15:47:11 PDT 2020


aardappel added a comment.

@aheejin Apologies if you think I ignored your comments, I feel I responded to all of them, though maybe I could have responded earlier (I wanted to first bring up your point about adjacency in the debugging subgroup meeting yesterday).

WebAssemblyDebugValueManager: ah, didn't see that.. I guess it makes them adjacent when it clones/moves them.

As for the loop in reverse.. I did think of that, but given the average expected stack depth, I didn't think it was necessary.. would be happy to add it though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79428/new/

https://reviews.llvm.org/D79428





More information about the llvm-commits mailing list