[PATCH] D79151: build: use `find_package(Python3)` if available (llvm runtimes).

Fri May 15 15:14:30 PDT 2020

compnerd added inline comments.

================
Comment at: llvm/runtimes/CMakeLists.txt:118
+    include(FindPythonInterp)
+    if( NOT PYTHONINTERP_FOUND )
+      message(FATAL_ERROR
----------------
vvereschaka wrote:
> compnerd wrote:
> > This was not fatal previously was it?  Why make it fatal now?
> It was fatal in commit https://github.com/llvm/llvm-project/commit/c4c3883b00d3a6aa657a5e3e515c90c9ea1f81c6
> I just did copy/paste into a proper location.
Sure, because those projects used it with a failure being fatal.  Here, the check is being performed without it being fatal.  Note that there was no check in the CMakeLists.txt which checked if the python interpreter was found.  If that exists, we should remove the old check and keep the check here only.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79151/new/

https://reviews.llvm.org/D79151