[PATCH] D78884: [CMake] -gen-dag-isel: add -omit-comments if neither Debug nor RelWithDebInfo
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 15 14:10:17 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa63eedd049bf: [CMake] -gen-dag-isel: add -omit-comments if neither Debug nor RelWithDebInfo (authored by MaskRay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78884/new/
https://reviews.llvm.org/D78884
Files:
llvm/cmake/modules/TableGen.cmake
Index: llvm/cmake/modules/TableGen.cmake
===================================================================
--- llvm/cmake/modules/TableGen.cmake
+++ llvm/cmake/modules/TableGen.cmake
@@ -53,6 +53,15 @@
list(APPEND LLVM_TABLEGEN_FLAGS "-gisel-coverage-file=${LLVM_GISEL_COV_PREFIX}all")
endif()
endif()
+ # Comments are only useful for Debug builds. Omit them if the backend
+ # supports it.
+ if (NOT (uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" OR
+ uppercase_CMAKE_BUILD_TYPE STREQUAL "RELWITHDEBINFO"))
+ list(FIND ARGN "-gen-dag-isel" idx)
+ if (NOT idx EQUAL -1)
+ list(APPEND LLVM_TABLEGEN_FLAGS "-omit-comments")
+ endif()
+ endif()
# MSVC can't support long string literals ("long" > 65534 bytes)[1], so if there's
# a possibility of generated tables being consumed by MSVC, generate arrays of
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78884.264340.patch
Type: text/x-patch
Size: 855 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200515/86e4ff03/attachment.bin>
More information about the llvm-commits
mailing list