[PATCH] D79997: [DebugInfo] Dump fields according to their formats.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good - might be good/better to commit per-section, to isolate the changes/testing/etc.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp:486
+      OS << format(" .debug_str[0x%0*" PRIx64 "] = ",
+                   Format == DWARF64 ? 16 : 8, UValue);
     dumpString(OS);
----------------
maybe pull this 16/8 computation out to the top, as you have in other parts of this patch? and/or refactor it into a utility function that gives the offset length, given the DWARF format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79997/new/

https://reviews.llvm.org/D79997