[PATCH] D79931: [mlir][spirv] Handle debuginfo for control flow ops.

[Lei Zhang via Phabricator via llvm-commits]

antiagainst accepted this revision.
antiagainst added a comment.
This revision is now accepted and ready to land.

Awesome, thanks Denis!



================
Comment at: mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp:395
+  /// OpLine in the block must be before its merge instruction".
+  bool lastProcessedWasMergeInst = false;
+
----------------
Super nit: can this be placed after the `emitDebugInfo` field? It's logically a field necessitated by `emitDebugInfo` so appearing after it would be nice. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79931/new/

https://reviews.llvm.org/D79931