[PATCH] D79920: [llvm][NFC] Simplify ProfileSummaryInfo state transitions.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 11:25:18 PDT 2020


dblaikie added a comment.

Could you separate all the constification (& possibly/as much of the renaming as possible) from the semantic changes here?

(no need to send the constification for pre-commit review - feel free to commit it before or after the semantic changes depending on what suits/is practical/etc)



================
Comment at: llvm/include/llvm/Analysis/ProfileSummaryInfo.h:66
   /// Returns true if profile summary is available.
-  bool hasProfileSummary() { return computeSummary(); }
+  bool hasProfileSummary() const { return !!Summary; }
 
----------------
I'd probably write this as `Summary != nullptr`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79920/new/

https://reviews.llvm.org/D79920





More information about the llvm-commits mailing list