[PATCH] D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link()

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

Seems good, could please remove the unrelated clang-format changes?
Do you have commit access?



================
Comment at: lld/COFF/Writer.cpp:72
+    0x20, 0x72, 0x75, 0x6e, 0x20, 0x69, 0x6e, 0x20, 0x44, 0x4f, 0x53, 0x20,
+    0x6d, 0x6f, 0x64, 0x65, 0x2e, 0x24, 0x00, 0x00};
 static_assert(sizeof(dosProgram) % 8 == 0,
----------------
Anything unrelated like this line change should be removed from the patch. We could run clang-format separately on the files after.


================
Comment at: lld/COFF/Writer.cpp:104
 
-    for (const std::pair<COFF::DebugType, Chunk *>& record : records) {
+    for (const std::pair<COFF::DebugType, Chunk *> &record : records) {
       Chunk *c = record.second;
----------------
Remove change.


================
Comment at: lld/COFF/Writer.cpp:305
 
-void OutputSection::addChunk(Chunk *c) {
-  chunks.push_back(c);
-}
+void OutputSection::addChunk(Chunk *c) { chunks.push_back(c); }
 
----------------
Remove change.


================
Comment at: lld/COFF/Writer.cpp:845
       name = name.split('$').first;
-    PartialSection *pSec = createPartialSection(name,
-                                                c->getOutputCharacteristics());
+    PartialSection *pSec =
+        createPartialSection(name, c->getOutputCharacteristics());
----------------
Remove change.


================
Comment at: lld/COFF/Writer.cpp:1865
   if (config->machine == AMD64) {
-    struct Entry { ulittle32_t begin, end, unwind; };
+    struct Entry {
+      ulittle32_t begin, end, unwind;
----------------
Please remove this change as well as the one below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70378/new/

https://reviews.llvm.org/D70378