[PATCH] D79707: [IR][BFloat] add BFloat IR intrinsics support

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added a comment.

Hi @stuij ,

thank you for working on this.

I only have a comment on scalable vectors.

Francesco



================
Comment at: llvm/include/llvm/IR/Intrinsics.td:283
 def llvm_v8f16_ty      : LLVMType<v8f16>;    //  8 x half (__fp16)
+def llvm_v2bf16_ty     : LLVMType<v2bf16>;   //  2 x bfloat (__bf16)
+def llvm_v4bf16_ty     : LLVMType<v4bf16>;   //  4 x bfloat (__bf16)
----------------
Can you add the scalable version of these in `IntrinsicsAArch64.td`, together with those already there?
```
frapet01 at man-08:~/projects/upstream-clang/llvm-project/llvm/include/llvm/IR (5225-LLVM)$ grep "def llvm_nx" *
IntrinsicsAArch64.td:def llvm_nxv2i1_ty  : LLVMType<nxv2i1>;
IntrinsicsAArch64.td:def llvm_nxv4i1_ty  : LLVMType<nxv4i1>;
IntrinsicsAArch64.td:def llvm_nxv8i1_ty  : LLVMType<nxv8i1>;
IntrinsicsAArch64.td:def llvm_nxv16i1_ty : LLVMType<nxv16i1>;
IntrinsicsAArch64.td:def llvm_nxv16i8_ty : LLVMType<nxv16i8>;
IntrinsicsAArch64.td:def llvm_nxv4i32_ty : LLVMType<nxv4i32>;
IntrinsicsAArch64.td:def llvm_nxv2i64_ty : LLVMType<nxv2i64>;
IntrinsicsAArch64.td:def llvm_nxv8f16_ty : LLVMType<nxv8f16>;
IntrinsicsAArch64.td:def llvm_nxv4f32_ty : LLVMType<nxv4f32>;
IntrinsicsAArch64.td:def llvm_nxv2f64_ty : LLVMType<nxv2f64>;
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79707/new/

https://reviews.llvm.org/D79707