[PATCH] D79963: [llvm][test] Add COM: directives before colon-less non-CHECKs in comments. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 08:39:40 PDT 2020


MaskRay added a comment.

`; COM:` seems non-obvious and harms readability. The inconvenience may discourage contributors from writing comments.
For file types using `;` or `#` as line comment markers, won't `;; ` or `## ` be clearer?
Personally I use `;; ` and `## ` for new tests all the time since I learned the practice, however, I would be hesitant to enforce this because others' tendency may be different.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79963/new/

https://reviews.llvm.org/D79963





More information about the llvm-commits mailing list