[PATCH] D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d

Fri May 15 08:39:37 PDT 2020

RKSimon added a comment.

Really we need to stop creating nodes inside getFauxShuffle - I'm going to see if we can do this without too many regressions.

================
Comment at: llvm/test/CodeGen/X86/simplifydemandedvectorselts-broadcast.ll:20
+  %ptr = addrspacecast <3 x i32> addrspace(1)* %1 to <3 x i32> addrspace(4)*
+  %int3 = load <3 x i32>, <3 x i32> addrspace(4)* %ptr, align 1
+  %2 = shufflevector <3 x i32> %int3, <3 x i32> undef, <16 x i32> <i32 0, i32 1, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef, i32 undef>
----------------
these bitcasts can probably be removed ? or at very least the addrspace ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79987/new/

https://reviews.llvm.org/D79987