[PATCH] D70378: [LLD][COFF] Fix missing cache cleanup in COFF::link()

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: lld/COFF/Driver.cpp:93
   TpiSource::clear();
+  OutputSection::outputSections.clear();
 
----------------
Sorry for making you change another time, but I think the code would look better if following the existing nomenclature: `OutputSection::instances`.


================
Comment at: lld/COFF/Writer.cpp:1075
+  OutputSection::outputSections.erase(
+      std::remove_if(OutputSection::outputSections.begin(), OutputSection::outputSections.end(), isEmpty),
+      OutputSection::outputSections.end());
----------------
You need to run `git clang-format` on your changes before uploading the patch. You simply need to add `clang/tools/clang-format/git-clang-format` and a copy of `clang-format.exe` somewhere in your `%PATH%` (if running on Windows).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70378/new/

https://reviews.llvm.org/D70378