[PATCH] D79859: [ARM][MVE] Add support for incrementing scatters

[Anna Welker via Phabricator via llvm-commits]

anwel added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:608
+  else
+    Ty = dyn_cast<VectorType>(I->getArgOperand(0)->getType());
   // Incrementing gathers only exist for v4i32
----------------
dmgreen wrote:
> Does this need to be a dyn_cast? Can it ever not be a vector?
After further consideration, no, the GetElementPtr that is given to a scatter should always be a vector type instruction.


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:731
 
-  // Build the incrementing gather
-  Value *Load = tryCreateMaskedGatherBaseWB(I, Phi, Builder, Immediate);
-
-  // One value to be handed to whoever uses the gather, one is the loop
-  // increment
-  Value *ExtractedLoad = Builder.CreateExtractValue(Load, 0, "Gather");
-  Value *Inc = Builder.CreateExtractValue(Load, 1, "GatherIncrement");
+  Value *Endresult;
+  Value *NewInduction;
----------------
dmgreen wrote:
> Endresult -> EndResult
Sure


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79859/new/

https://reviews.llvm.org/D79859