[PATCH] D79984: [yaml2obj] - Add a technical prefix for each unnamed chunk.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 00:52:28 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: hiraditya, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar added a child revision: D79985: [yaml2obj] - Move "repeated section/fill name" check earlier..
grimar edited the summary of this revision.
grimar edited the summary of this revision.
grimar added a comment.

D79985 <https://reviews.llvm.org/D79985> depends on this, but it can live without it. I am going to post another patch soon that is using `SN2I` and requires this change.


This change does not affect the produced binary.

In this patch I assign a technical prefix to each section/fill
(i.e. chunk) name when it is empty. It allows to simplify the code
slightly and improve error messages reported.

In the code we have the section to index mapping, `SN2I`, which is
globally used. With this change we can use it to map "empty"
names to indexes now, what is helpful, I am using it in
another patch (will post it soon).


https://reviews.llvm.org/D79984

Files:
  llvm/lib/ObjectYAML/ELFEmitter.cpp
  llvm/test/tools/yaml2obj/ELF/custom-null-section.yaml
  llvm/test/tools/yaml2obj/ELF/section-link.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79984.264170.patch
Type: text/x-patch
Size: 5529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200515/b5ab7bd6/attachment-0001.bin>


More information about the llvm-commits mailing list