[PATCH] D79982: [ELF] Use namespace qualifiers

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 23:22:39 PDT 2020


MaskRay created this revision.
MaskRay added reviewers: grimar, psmith, ruiu.
Herald added subscribers: llvm-commits, kerbowa, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, dexonsmith, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, fedor.sergeev, kbarton, hiraditya, arichardson, nhaehnle, jvesely, nemanjai, sdardis, emaste, dylanmckay, jyknight.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This reverts much code from commit
bd8cfe65f5fee4ad573adc2172359c9552e8cdc0 (D68323 <https://reviews.llvm.org/D68323>) and fixes some
problems before D68323 <https://reviews.llvm.org/D68323>.

Sorry for the churn but D68323 <https://reviews.llvm.org/D68323> was a mistake. Namespace qualifiers avoid
bugs where the definition does not match the declaration from the
header. See
https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions (D74515 <https://reviews.llvm.org/D74515>)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79982

Files:
  lld/ELF/Arch/AArch64.cpp
  lld/ELF/Arch/AMDGPU.cpp
  lld/ELF/Arch/ARM.cpp
  lld/ELF/Arch/AVR.cpp
  lld/ELF/Arch/Hexagon.cpp
  lld/ELF/Arch/MSP430.cpp
  lld/ELF/Arch/Mips.cpp
  lld/ELF/Arch/MipsArchTree.cpp
  lld/ELF/Arch/PPC.cpp
  lld/ELF/Arch/PPC64.cpp
  lld/ELF/Arch/RISCV.cpp
  lld/ELF/Arch/SPARCV9.cpp
  lld/ELF/Arch/X86.cpp
  lld/ELF/Arch/X86_64.cpp
  lld/ELF/CallGraphSort.cpp
  lld/ELF/DWARF.cpp
  lld/ELF/Driver.cpp
  lld/ELF/DriverUtils.cpp
  lld/ELF/EhFrame.cpp
  lld/ELF/ICF.cpp
  lld/ELF/InputFiles.cpp
  lld/ELF/InputFiles.h
  lld/ELF/InputSection.cpp
  lld/ELF/LTO.cpp
  lld/ELF/LinkerScript.cpp
  lld/ELF/MapFile.cpp
  lld/ELF/MarkLive.cpp
  lld/ELF/OutputSections.cpp
  lld/ELF/Relocations.cpp
  lld/ELF/ScriptLexer.cpp
  lld/ELF/ScriptParser.cpp
  lld/ELF/SymbolTable.cpp
  lld/ELF/Symbols.cpp
  lld/ELF/Symbols.h
  lld/ELF/SyntheticSections.cpp
  lld/ELF/Target.cpp
  lld/ELF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79982.264162.patch
Type: text/x-patch
Size: 56003 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200515/8c455631/attachment.bin>


More information about the llvm-commits mailing list