[PATCH] D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 21:56:29 PDT 2020


dstenb added a comment.

In D78107#2029294 <https://reviews.llvm.org/D78107#2029294>, @ntesic wrote:

> In beginInstruction() guard we should expect that delay slot instruction is immediately after call instruction, before label insertion.
>  In constructCallSiteEntryDIEs() guard we should expect that both the call instruction and its successor are followed by the same label.
>
> @dstenb @vsk @djtodoro Thanks for your comments and, please,
>  let me know what do you think about this approach.


Sorry for the delay! Adding such assertions sounds good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78107/new/

https://reviews.llvm.org/D78107





More information about the llvm-commits mailing list