[PATCH] D79977: [ELF][PPC64] Synthesize _savegpr[01]_{14..31} and _restgpr[01]_{14..31}

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 2 inline comments as done.
MaskRay added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: lld/ELF/Arch/PPC64SaveRest.cpp:61
+  printf ".globl "
+  for(i=14;i<32;i++) { printf "_restgpr0_" i (i==31?"\n":",") }
+  for(i=14;i<29;i++) { print "_restgpr0_" i ": " s "ld " i "," (i*8-256) "(1)" }
----------------
I should add `.hidden ` as well.


================
Comment at: lld/test/ELF/ppc64-savegpr1.s:14
+# RUN: ld.lld %t31.o -o %t31
+# RUN: llvm-objdump -d --no-show-raw-insn %t31 | FileCheck %s
+
----------------
I should change one test to check `-shared`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79977/new/

https://reviews.llvm.org/D79977