[PATCH] D79867: [VectorUtils] Expose vector-function-abi-variant mangling as a utility. NFC

[Anna Thomas via Phabricator via llvm-commits]

anna marked an inline comment as done.
anna added inline comments.


================
Comment at: llvm/unittests/Analysis/VectorFunctionABITest.cpp:94-95
+        VectorNameArg, ScalarNameArg, NumArgs, VFArg);
+    // Testing if the mangledname that is generated can be demangled and the
+    // correct values are retrieved.
+    reset(VectorNameArg, IRType);
----------------
fpetrogalli wrote:
> I don't think we need this. The demangler is already tested extensively. If some tests are missing, I think it is better to add them separately as demangler tests.
> 
> I think all we need here (in the body of the test below) is just a couple of invocation of the API that makes sure that the correct string is generated. Something like:
> 
> ```
> EXPECT_EQ(VFABI::mangleTLIVectorName( "vec", "scalar", 3, 4),"_ZGV_LLVM_N4vvv_scalar(vec)");
> EXPECT_EQ(VFABI::mangleTLIVectorName( "A", "B", 4, 5), "_ZGV_LLVM_N5vvvv_B(A)");
> ```
okay, I like that idea of decoupling them. Yeah, just checked - we handle all of these in the demangler case. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79867/new/

https://reviews.llvm.org/D79867