[PATCH] D79922: [MLIR] Allow unreachable blocks to violate dominance property.

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 15:15:05 PDT 2020


lattner accepted this revision.
lattner added a comment.

This looks great, thank you!



================
Comment at: mlir/lib/IR/Verifier.cpp:228
+    // Dominance is only reachable inside reachable blocks.
+    if(domInfo->isReachableFromEntry(&block))
+      for (auto &op : block) {
----------------
Please run clang format on this in the LLVM Style.  You need a space after the 'if' and put the brace below on the same line as the 'else'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79922/new/

https://reviews.llvm.org/D79922





More information about the llvm-commits mailing list