[PATCH] D79899: [MLIR] Move JitRunner to live with ExecutionEngine

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer marked 2 inline comments as done.
stephenneuendorffer added inline comments.


================
Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:16
 
   EXCLUDE_FROM_LIBMLIR
 
----------------
mehdi_amini wrote:
> This is off-topic, but this should be documented (the code you deleted had a comment to this end).
> Isn't the JIT infra mostly coming from libLLVM.so and so shouldn't be a "big dependency"?
> 
The same comment is now at the top of this file, intending to apply to all of the libraries here.

Your comment is true.  I was thinking about trying to keep the size of binaries like mlir-opt down relative to mlir-cpu-runner.  However once everything is linked into libLLVM.so/libMLIR.so there's maybe not much to be gained.  Probably worth experimenting with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79899/new/

https://reviews.llvm.org/D79899