[PATCH] D79956: [InstCombine] Teach PromoteCastOfAllocation to not insert a bitcast into the middle of a group of allocas

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

So for the originally reported issue, it looks like in StackColoring::remapInstructions   To is later than From in the basic block. And there's a use of From between them. So when From is replaced with To we create bad IR. So we need to move To to From if From is earlier? Or if there is a user of From that's earlier than To? I think the code does walk all uses of From already.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79956/new/

https://reviews.llvm.org/D79956