[PATCH] D79042: [llvm] Add interface to drive inlining decision using ML model

Thu May 14 14:08:37 PDT 2020

mtrofin added a comment.

In D79042#2037194 <https://reviews.llvm.org/D79042#2037194>, @leonardchan wrote:

> Hello, a bisect seems to show this breaks our 2 stage toolchain build from assertion errors:
>
>   [12/3658] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/APFloat.cpp.o
>   FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/APFloat.cpp.o 
>   /b/s/w/ir/cache/goma/client/gomacc /b/s/w/ir/k/recipe_cleanup/clangy7u70P/llvm_build_dir/./bin/clang++ --sysroot=/b/s/w/ir/k/cipd/linux-amd64  -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/b/s/w/ir/k/llvm-project/llvm/lib/Support -I/b/s/w/ir/k/recipe_cleanup/clangy7u70P/libxml2_install/include/libxml2 -Iinclude -I/b/s/w/ir/k/llvm-project/llvm/include -I/b/s/w/ir/k/recipe_cleanup/clangy7u70P/zlib_install/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wno-comment -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -flto -ffile-prefix-map=/b/s/w/ir/k/recipe_cleanup/clangy7u70P/llvm_build_dir/tools/clang/stage2-bins=../recipe_cleanup/clangy7u70P/llvm_build_dir/tools/clang/stage2-bins -ffile-prefix-map=/b/s/w/ir/k/llvm-project/= -no-canonical-prefixes -O3 -DNDEBUG   -std=c++14  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/APFloat.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/APFloat.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/APFloat.cpp.o -c /b/s/w/ir/k/llvm-project/llvm/lib/Support/APFloat.cpp
>   clang++: /b/s/w/ir/k/llvm-project/llvm/lib/Analysis/CodeMetrics.cpp:104: static void llvm::CodeMetrics::collectEphemeralValues(const llvm::Function *, llvm::AssumptionCache *, SmallPtrSetImpl<const llvm::Value *> &): Assertion `I->getParent()->getParent() == F && "Found assumption for the wrong function!"' failed.
>   clang++: error: clang frontend command failed due to signal (use -v to see invocation)
>   Fuchsia clang version 11.0.0 (https://fuchsia.googlesource.com/a/third_party/llvm-project 9ed9860d8774b364412ce50bf5d59a8eaee1adb7)
>   Target: x86_64-unknown-linux-gnu
>   Thread model: posix
>   InstalledDir: /b/s/w/ir/k/recipe_cleanup/clangy7u70P/llvm_build_dir/./bin
>   clang++: note: diagnostic msg: 
>   ********************
>  
>   PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
>   Preprocessed source(s) and associated run script(s) are located at:
>   clang++: note: diagnostic msg: /tmp/APFloat-fb32b4.cpp
>   clang++: note: diagnostic msg: /tmp/APFloat-fb32b4.sh
>   clang++: note: diagnostic msg: 
>  
>   ********************
>
>
> Would you mind taking a look and sending out a fix or reverting? Thanks.
>
> Builder: https://luci-milo.appspot.com/p/fuchsia/builders/prod/clang-linux-x64/b8880367188790280224

Looking right now - thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79042/new/

https://reviews.llvm.org/D79042