[PATCH] D79956: [InstCombine] Teach PromoteCastOfAllocation to not insert a bitcast into the middle of a group of allocas

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

FWIW, I don't think we have the alloca grouping as a rigorous requirement. Without doing that, which basically means teaching the verifier and putting it the lang ref, this might be(come) a long term game of whack-a-mole.

That said, I don't have a problem with the patch, just want to mention that this might not be the way we want to go. I mean, let's go all in on the grouping or not at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79956/new/

https://reviews.llvm.org/D79956