[PATCH] D79957: Responses to review comments

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld created this revision.
PeteSteinfeld added reviewers: tskeith, klausler.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

I changed the error messages to specify that errors in specification
expressions could arise from either bad derived type components or type
parameters.

I moved error detection for constraint C756 from resolve-names.cpp to
check-declarations.cpp.

I collapsed a nested `if` statement to a single `if` with a more complex
condition.

In cases where we detect a type param that was not declared, I created a symbol
marked as erroneous.  That avoids subsequent semantic process for expressions
containing the symbol.  This change caused me to adjust tests resolve33.f90 and
resolve34.f90.  Also, I avoided putting out error messages for erroneous type
param symbols in `OkToAddComponent()` in resolve-names.cpp and in
`EvaluateParameters()`, type.cpp.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79957

Files:
  flang/lib/Evaluate/check-expression.cpp
  flang/lib/Semantics/check-declarations.cpp
  flang/lib/Semantics/resolve-names.cpp
  flang/lib/Semantics/type.cpp
  flang/test/Semantics/resolve33.f90
  flang/test/Semantics/resolve34.f90
  flang/test/Semantics/resolve79.f90
  flang/test/Semantics/resolve89.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79957.264056.patch
Type: text/x-patch
Size: 17424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200514/6e3815b3/attachment.bin>