[PATCH] D79907: [AMDGPU] Peephole adjacent equivalent S_SET_GPR_IDX_ON

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 16:24:16 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp:225-228
+      if (Count == Threshold)
+        SetGPRMI = nullptr;
+      else
+        ++Count;
----------------
I'm confused by this usage of threshold. You never break from the loop on it and it's not part of the loop condition


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79907/new/

https://reviews.llvm.org/D79907





More information about the llvm-commits mailing list