[PATCH] D79898: [AMDGPU] Optimized indirect multi-VGPR addressing

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1905
     // the base (n0) to be negative.
-    if (C1->getSExtValue() <= 0 || CurDAG->SignBitIsZero(N0)) {
+    // (or n0, c0) can never change a sign given isBaseWithConstantOffset.
+    if (C1->getSExtValue() <= 0 || CurDAG->SignBitIsZero(N0) ||
----------------
Couldn't it change the sign for (or 0, 0x80000000)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79898/new/

https://reviews.llvm.org/D79898