[PATCH] D78342: [lld] Add archive file support to Mach-O backend

[Kellie Medlin via Phabricator via llvm-commits]

Ktwu added inline comments.


================
Comment at: lld/test/MachO/Inputs/archive2.s:3
+_boo:
+  mov $2, %rax
+  ret
----------------
int3 wrote:
> can we drop the `mov` commands in the archive input files even if we're not inlining them?
I'll inline and drop the mov; these files are basically identical to the symbol-order tests at this point so they might as well be inlined...


================
Comment at: lld/test/MachO/symbol-order.s:9
+
+## lld -flavor darwinnew
+# RUN: lld -flavor darwinnew -dylib -o %t/libf1.dylib %t/f1.o
----------------
int3 wrote:
> intentional comment?
Not intentionally at all; I added this when running the retweaked test against the system linker...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78342/new/

https://reviews.llvm.org/D78342