[PATCH] D79820: [test] Improve FileCheck's numeric-expression.txt

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:156
+USE MULTI VAR  // CHECK-LABEL: USE MULTI VAR
+31  // CHECK-NEXT: {{^}}[[#VAR4:]]
+42  // CHECK-NEXT: {{^}}[[#UNSI+VAR4]]
----------------
For consistency with VAR42, should VAR4 become VAR31?


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:228-236
 STRVAR NUMVAR CONFLICT
 redef1 42
 foobar
 redef2 42
 CONFLICT-LABEL: STRVAR NUMVAR CONFLICT
 CONFLICT1-NEXT: redef1 [[#NUMVAR:]]
 CONFLICT2: [[NUMVAR:foo.*]]
----------------
Can these checks be inlined like the others?


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:269-274
 DEF EXPR WRONG MATCH
 20
 43
 DEF-EXPR-FAIL-LABEL: DEF EXPR WRONG MATCH
 DEF-EXPR-FAIL-NEXT: [[# VAR20:]]
 DEF-EXPR-FAIL-NEXT: [[# VAR42: VAR20+22]]
----------------
Can these checks be inlined?


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:288-293
 SAME LINE USE
 3
 4 5
 SAME-LINE-USE1-LABEL: SAME LINE USE
 SAME-LINE-USE1-NEXT: [[#]]
+SAME-LINE-USE1-NEXT: [[#UNSI:]] [[#UNSI+1]]
----------------
Can these checks be inlined?


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:310-315
 VAR REDEF FMT CHANGE
 22
 DC
 REDEF-NEW-FMT-LABEL: VAR REDEF FMT CHANGE
-REDEF-NEW-FMT-NEXT: [[#VAR1:]]
-REDEF-NEW-FMT-NEXT: [[#%X,VAR1:]]
+REDEF-NEW-FMT-NEXT: [[#UNSI:]]
+REDEF-NEW-FMT-NEXT: [[#%X,UNSI:]]
----------------
Can these checks be inlined?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79820/new/

https://reviews.llvm.org/D79820