[PATCH] D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added a comment.

Thanks! I measured time and memory usage on a particular binary, and this change had no measurable effect, which is good.



================
Comment at: lld/COFF/PDB.cpp:990
+      return;
+    warnUnusable(obj, Error::success());
+    // Even if there're no types, still merge non-symbol .Debug$S and .Debug$F
----------------
Before committing, I discovered that this results in warnings on any object that lacks debug info, such as the ones in the CRT. I don't think this warning is necessary, so I'll remove it and commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79672/new/

https://reviews.llvm.org/D79672