[PATCH] D79165: [DebugInfo] - DWARFDebugFrame: do not call abort() on errors.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 09:11:12 PDT 2020


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:819
                                     isLittleEndian(), DObj->getAddressSize());
-  DebugFrame.reset(new DWARFDebugFrame(getArch(), false /* IsEH */));
-  DebugFrame->parse(debugFrameData);
+  std::unique_ptr<DWARFDebugFrame> DF =
+      std::make_unique<DWARFDebugFrame>(getArch(), /*IsEH=*/false);
----------------
auto because the type is obvious from `make_unique`


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:835
+
+  std::unique_ptr<DWARFDebugFrame> DF =
+      std::make_unique<DWARFDebugFrame>(getArch(), /*IsEH=*/true);
----------------
auto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79165/new/

https://reviews.llvm.org/D79165





More information about the llvm-commits mailing list