[PATCH] D79941: [NFCI][CostModel] Refactor getIntrinsicInstrCost

[Anna Welker via Phabricator via llvm-commits]

anwel added a comment.

Hi Sam, those tests are checking whether the cost model calculates the costs for `zext(gather(...)) `and  `scatter(trunc(..))` correctly, because these can be integrated in the MVE intrinsics.
That calculation relies on `I` being available. I see that you did integrate `I` in `IntrinsicCostAttributes`, as an `IntrinsicInst`; the gather/scatter cost function was taking an `Instruction` because when it is called we might either be looking at a gather/scatter intrinsic or still at an LLVM load/store, which I think is no intrinsic?
I can't see where it happens, but my guess is that the instruction that ends up being handed over to `getGatherScatterOpCost` in `BasicTTIImpl::getIntrinsicInstrCost` doesn't match what was expected anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79941/new/

https://reviews.llvm.org/D79941