[PATCH] D79820: [test] Improve FileCheck's numeric-expression.txt

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D79820#2036406 <https://reviews.llvm.org/D79820#2036406>, @jdenny wrote:

> In D79820#2035779 <https://reviews.llvm.org/D79820#2035779>, @jhenderson wrote:
>
> > LGTM, but please wait for @jdenny to confirm.
>
>
> Other than the comment I just added, this much LGTM as well.
>
> > Is there any particular reason for you not to make the same improvements, re. comments inline, on the other sets of tests?
>
> Agreed.


I went a bit further and renamed the variable as suggested by James in D60390 <https://reviews.llvm.org/D60390>. I've also changed {{.*}} for {{^}} which is both shorter, less demanding of the regular expression engine and make directive naturally aligned instead of having to use whitespaces at the end. Do you approve those changes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79820/new/

https://reviews.llvm.org/D79820