[PATCH] D79328: lld: Let find_package(LLD) work

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked 5 inline comments as done.
arsenm added inline comments.


================
Comment at: lld/cmake/modules/CMakeLists.txt:33
+# Compute the installation prefix from this LLVMConfig.cmake file location.
+get_filename_component(LLD_INSTALL_PREFIX \"\${CMAKE_CURRENT_LIST_FILE}\" PATH)")
+# Construct the proper number of get_filename_component(... PATH)
----------------
MaskRay wrote:
> Does this need an indentation?
None of this is indented, although it does look like it is in phabricator for some reason.


================
Comment at: lld/cmake/modules/LLDConfig.cmake.in:18
+# in-tree with lld or not.
+if(NOT TARGET lld-tablegen-targets)
+  add_custom_target(lld-tablegen-targets)
----------------
MaskRay wrote:
> Is this used?
Don't think so. It looks like clang sets this property up itself for generated headers. The tablegen uses in lld look like they only produce private .inc files


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79328/new/

https://reviews.llvm.org/D79328