[PATCH] D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR

[Alex Zinenko via Phabricator via llvm-commits]

ftynse requested changes to this revision.
ftynse added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:320
   }
+  // flush Construct: !$omp flush [(list)]
+  // flush with a list is treated same as a flush without a list by ignoring
----------------
Let's not use Fortran syntax in C++ code


================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:321
+  // flush Construct: !$omp flush [(list)]
+  // flush with a list is treated same as a flush without a list by ignoring
+  // the list.
----------------
This comment doesn't seem to belong here


================
Comment at: mlir/test/Dialect/OpenMP/ops.mlir:27
+  // Test with one data var
+  // CHECK: omp.flush
+  "omp.flush"(%data_var) : (memref<i32>) -> ()
----------------
This doesn't actually check that you print back operands


================
Comment at: mlir/test/Dialect/OpenMP/ops.mlir:28
+  // CHECK: omp.flush
+  "omp.flush"(%data_var) : (memref<i32>) -> ()
+
----------------
Could we rather use the custom format?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79937/new/

https://reviews.llvm.org/D79937