[PATCH] D79880: [LLD][ELF] Use offset in thin archives to disambiguate thinLTO members

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: lld/test/ELF/lto/thinlto.ll:65
 ; RUN: ld.lld -save-temps %t1.o %t.dir/t.a -o %t.null
-; RUN: ls '%t.dir/t.a(t.o at 0).0.preopt.bc'
+; RUN: ls %t.dir/t.a*.0.preopt.bc
 
----------------
hoyFB wrote:
> Attempting to make it work on Windows platform which looks like the diff time testing is performed on and with the failure:
> 
>    $ ":" "RUN: at line 65"
>    $ "ls" "C:\ws\prod\llvm-project\build\tools\lld\test\ELF\lto\Output\thinlto.ll.tmp.dir/t.a\(t.o\" "at\" "*\).0.preopt.bc"
>    # command stderr:
>    s: C:\ws\prod\llvm-project\build\tools\lld\test\ELF\lto\Output\thinlto.ll.tmp.dir/t.a\(t.o\: No such file or directory
>    ls: at\: No such file or directory
>    l.s: *\).0.preopt.bc: Invalid argument
I think that on Windows only double-quotes are recognized as a quotation mark and single-quotes are just regular characters. So you can probably change `'` to `"`. Using `*` is fine though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79880/new/

https://reviews.llvm.org/D79880