[PATCH] D79064: [test-suite] Register result codes with lit.

[Michael Kruse via llvm-commits]

This patch makes the test-suite master work with llvm-project's
master, which IMHO should take precedence over users using older
versions of lit with newer version of test-suite for whatever reason.
Not having the two masters consistent does break most buildbot setups,
including LLVM's own.

I could offer to commit a workaround which only calls
add_result_category if it exists:

try:
  lit.main.add_result_category(NOCHANGE, "Executable Unchanged")
  lit.main.add_result_category(NOEXE, "Executable Missing")
except:
  # add_result_category was added in newer version of lit
  pass

If you insist on reverting this, I suggest to revert
rGfbdcfcd4c392c487c411632b951f4aada351154e as well.

Michael


Am Mi., 13. Mai 2020 um 18:57 Uhr schrieb Jessica Paquette via
Phabricator <reviews at reviews.llvm.org>:
>
> paquette added subscribers: tstellar, ddunbar, paquette.
> paquette added a comment.
>
> Just as a heads up, it seems that this commit breaks anyone using the lit in pypi. (https://pypi.org/project/lit/)
>
> If you try using pypi's lit with this commit (say by running the test suite with LNT), you'll get
>
>   AttributeError: 'function' object has no attribute 'add_result_category'
>
> Would it be possible to temporarily back this out until that lit has been updated? (cc: @tstellar @ddunbar)
>
>
> Repository:
>   rT test-suite
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D79064/new/
>
> https://reviews.llvm.org/D79064
>
>
>