[PATCH] D79097: [GVN] Improve analysis for missed optimization remark

[Adam Nemet via Phabricator via llvm-commits]

anemet added a comment.

Sorry about the delay, just a few small nits on the tests, this is pretty close.  Thanks for pushing this!



================
Comment at: llvm/test/Transforms/GVN/opt-remarks-multiple-users.ll:3
+; RUN: cat %t | FileCheck %s
+
+; CHECK:      --- !Missed
----------------
Please add a comment with the intention for test.  In this particular case I imagine that before your change we would have given up on determining OtherAccess.


================
Comment at: llvm/test/Transforms/GVN/opt-remarks-multiple-users.ll:44
+  %add2 = add nsw i32 %1, %0
+  unreachable
+}
----------------
I know this is a minimized testcase but don’t have unreachable here to make it more realistic.  


================
Comment at: llvm/test/Transforms/GVN/opt-remarks-non-dominating.ll:61
+
+define dso_local void @multipleUsers1(i32* %a) local_unnamed_addr #0 {
+entry:
----------------
Please add a comment before each functions what it’s testing.


================
Comment at: llvm/test/Transforms/GVN/opt-remarks-non-dominating.ll:63
+entry:
+  br i1 undef, label %if.then, label %if.end
+
----------------
I would change these undefs to actual values to make these tests more realistic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79097/new/

https://reviews.llvm.org/D79097