[PATCH] D79064: [test-suite] Register result codes with lit.

[Tom Stellard via Phabricator via llvm-commits]

tstellar added a comment.

In D79064#2035476 <https://reviews.llvm.org/D79064#2035476>, @paquette wrote:

> In D79064#2035472 <https://reviews.llvm.org/D79064#2035472>, @tstellar wrote:
>
> > In D79064#2035470 <https://reviews.llvm.org/D79064#2035470>, @paquette wrote:
> >
> > > Just as a heads up, it seems that this commit breaks anyone using the lit in pypi. (https://pypi.org/project/lit/)
> > >
> > > If you try using pypi's lit with this commit (say by running the test suite with LNT), you'll get
> > >
> > >   AttributeError: 'function' object has no attribute 'add_result_category'
> > >
> > >
> > > Would it be possible to temporarily back this out until that lit has been updated? (cc: @tstellar @ddunbar)
> >
> >
> > What change do we need to pull into the pypi lit to fix this?
>
>
> Looks like rGfbdcfcd4c392c487c411632b951f4aada351154e <https://reviews.llvm.org/rGfbdcfcd4c392c487c411632b951f4aada351154e> should do the trick.


I was hoping this would be a bug fix, but it looks more like a feature.  We were planning to update lit on pypi for the 10.0.1 release, but this doesn't look like a good backport candidate to me.  Can we work-around this in the test suite somehow?


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79064/new/

https://reviews.llvm.org/D79064