[llvm] fa8c2ae - [X86] Return true from trySADReplacement in the partial reduction pass when a change is made.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 17:53:04 PDT 2020


Author: Craig Topper
Date: 2020-05-13T17:52:29-07:00
New Revision: fa8c2ae76f7e4f498d29e2716233bd29025e8827

URL: https://github.com/llvm/llvm-project/commit/fa8c2ae76f7e4f498d29e2716233bd29025e8827
DIFF: https://github.com/llvm/llvm-project/commit/fa8c2ae76f7e4f498d29e2716233bd29025e8827.diff

LOG: [X86] Return true from trySADReplacement in the partial reduction pass when a change is made.

Otherwise we don't signal to the pass manager that we changed IR.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86PartialReduction.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86PartialReduction.cpp b/llvm/lib/Target/X86/X86PartialReduction.cpp
index 3cc4d2682235..5cc928176794 100644
--- a/llvm/lib/Target/X86/X86PartialReduction.cpp
+++ b/llvm/lib/Target/X86/X86PartialReduction.cpp
@@ -405,7 +405,7 @@ bool X86PartialReduction::trySADReplacement(Value *Op, BinaryOperator *Add) {
   Add->setHasNoSignedWrap(false);
   Add->setHasNoUnsignedWrap(false);
 
-  return false;
+  return true;
 }
 
 bool X86PartialReduction::trySADPattern(BinaryOperator *BO) {


        


More information about the llvm-commits mailing list