[PATCH] D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor.

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:626
-    if ((*SI)->isEHPad() || *SI == TBB)
-      continue;
-    assert(!FallthroughBB && "Found more than one fallthrough successor.");
----------------
Does this new patch handle when a given layout successor is an EH pad? I might be mistaken, but I think that case should be excluded. But while this code is deleted, I can't find a similar counterpart in the new CL.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp:168
+          ? MF->getBlockNumbered(MBB->getNumber() + 1)
+          : nullptr;
+
----------------
Here for example.. this seems to takes the next layout block as a fallthrough, regardless of whether the layout successor is an EH pad or not... No?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79605/new/

https://reviews.llvm.org/D79605