[PATCH] D72947: [CMake] llvm/runtimes: Do not override LLVM_* variables with just-built LLVM configurations

Wed May 13 16:24:12 PDT 2020

JamesNagurne added a comment.

Actually, it's very fortuitous that you reminded of this review today.

There's an issue here, and I don't think I'd commit this upstream without understanding more.

LLVM recently moved towards Python3 and cmake updates. This means using find_package(Python) in some places
To save time, the python package search sets _Python_INTERPRETER_PROPERTIES, which is a list of information found about an interpreter. This ends up being a cache variable.

It's causing problems on our end when working with Windows builds with Python 3.8.2 and cmake 3.17

Do not commit this unless I can get a patch up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72947/new/

https://reviews.llvm.org/D72947