[PATCH] D79672: [COFF] Move type merging to TpiSource::mergeDebugT virtual method

Erik McClure via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 14:43:03 PDT 2020


blackhole12 added a comment.

It looks like this time around, the global list that was added has been properly cleaned up in link(), so this should be fine. Of course, the fixes that were mentioned <https://reviews.llvm.org/D70378> still haven't been merged, so as of right now LLVM 10's LLD linker crashes on windows when used multiple times, but apparently nobody cares about that right now. I can attempt to test this modification on my fork to see if it actually works, if people are willing to commit to actually fixing the memory cleanup errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79672/new/

https://reviews.llvm.org/D79672





More information about the llvm-commits mailing list