[PATCH] D79906: [MLIR][cmake] don't glob for sources.

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer created this revision.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, mgorny.
Herald added a reviewer: rriddle.
Herald added a project: LLVM.

Generally speaking, this is bad practice.  It also causes the build to
break if there are editor temporary files.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79906

Files:
  mlir/lib/Dialect/SCF/CMakeLists.txt
  mlir/lib/IR/CMakeLists.txt
  mlir/lib/Pass/CMakeLists.txt


Index: mlir/lib/Pass/CMakeLists.txt
===================================================================
--- mlir/lib/Pass/CMakeLists.txt
+++ mlir/lib/Pass/CMakeLists.txt
@@ -1,7 +1,11 @@
-file(GLOB globbed *.c *.cpp)
 add_mlir_library(MLIRPass
-  ${globbed}
-
+  IRPrinting.cpp
+  Pass.cpp
+  PassManagerOptions.cpp
+  PassRegistry.cpp
+  PassStatistics.cpp
+  PassTiming.cpp
+  
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Pass
 
Index: mlir/lib/IR/CMakeLists.txt
===================================================================
--- mlir/lib/IR/CMakeLists.txt
+++ mlir/lib/IR/CMakeLists.txt
@@ -1,6 +1,30 @@
-file(GLOB globbed *.c *.cpp)
 add_mlir_library(MLIRIR
-  ${globbed}
+  AffineExpr.cpp
+  AffineMap.cpp
+  AsmPrinter.cpp
+  Attributes.cpp
+  Block.cpp
+  Builders.cpp
+  Diagnostics.cpp
+  Dialect.cpp
+  Dominance.cpp
+  Function.cpp
+  FunctionImplementation.cpp
+  IntegerSet.cpp
+  Location.cpp
+  MLIRContext.cpp
+  Module.cpp
+  Operation.cpp
+  OperationSupport.cpp
+  PatternMatch.cpp
+  Region.cpp
+  StandardTypes.cpp
+  SymbolTable.cpp
+  Types.cpp
+  TypeUtilities.cpp
+  Value.cpp
+  Verifier.cpp
+  Visitors.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/IR
Index: mlir/lib/Dialect/SCF/CMakeLists.txt
===================================================================
--- mlir/lib/Dialect/SCF/CMakeLists.txt
+++ mlir/lib/Dialect/SCF/CMakeLists.txt
@@ -1,6 +1,5 @@
-file(GLOB globbed *.c *.cpp)
 add_mlir_dialect_library(MLIRSCF
-  ${globbed}
+  SCF.cpp
   EDSC/Builders.cpp
 
   ADDITIONAL_HEADER_DIRS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79906.263846.patch
Type: text/x-patch
Size: 1563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200513/4155e78b/attachment.bin>