[PATCH] D72321: Add test for GDB pretty printers.

Wed May 13 13:04:01 PDT 2020

csigg marked an inline comment as done.
csigg added inline comments.

================
Comment at: debuginfo-tests/CMakeLists.txt:5-9
+add_llvm_executable(prettyprinters
+        llvm-prettyprinters/gdb/prettyprinters.cpp
+)
+target_link_libraries(prettyprinters PRIVATE LLVMSupport)
+
----------------
dblaikie wrote:
> dblaikie wrote:
> > Might need to change the way this is built, @tbosch identified a bug where this test fails on a non-debug build of LLVM, because it doesn't explicitly request debug info, so it gets the build defaults. (either that, or the test should detect this situation - use a REQUIRES or similar to not run in the absence of debug info)
> > 
> > https://bugs.llvm.org/show_bug.cgi?id=45652
> @csigg ping on this ^ issue - could you take a look?
https://reviews.llvm.org/D79897 should fix it.
Sorry for the delay.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72321/new/

https://reviews.llvm.org/D72321