[PATCH] D79776: [AMDGPU] Allow use of StackPtrOffsetReg when building spills

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 13:04:01 PDT 2020


scott.linder accepted this revision.
scott.linder added a comment.

LGTM, although `CHECK`s in the tests to confirm that e.g. the first involves a scavenged register and `s_add`, and the second involves the stack pointer and `s_mov`, and that this happens at the expected offset might make it easier to read and more likely to catch something that breaks this in the future. Right now it isn't clear why there are two nearly identical tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79776/new/

https://reviews.llvm.org/D79776





More information about the llvm-commits mailing list