[PATCH] D79880: [LLD][ELF] Use offset in thin archives to disambiguate thinLTO members

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 11:58:05 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks good to me. Will be worth waiting a day or so to see if there are any further comments.



================
Comment at: lld/test/ELF/lto/thinlto-thinarchivecollision.ll:1
+; REQUIRES: x86
+; RUN: rm -fr %t && mkdir %t && cd %t
----------------
`thinlto-thin-archive-collision.ll`


================
Comment at: lld/test/ELF/lto/thinlto-thinarchivecollision.ll:8
+; RUN: llvm-ar qcT thinlto-archives/thin.a thinlto-archives/a/thin.o thinlto-archives/b/thin.o
+; RUN: ld.lld thinlto-archives/main.o thinlto-archives/thin.a -o thinlto-archives/main.exe -save-temps
+; RUN: FileCheck %s < thinlto-archives/main.exe.resolution.txt
----------------
`--save-temps`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79880/new/

https://reviews.llvm.org/D79880





More information about the llvm-commits mailing list