[PATCH] D79880: [LLD][ELF] Use offset in thin archives to disambiguate thinLTO members

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 10:50:41 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/thinlto-thinarchivecollision.ll:2
+; REQUIRES: x86
+; RUN: rm -fr %T/thinlto-archives
+; RUN: mkdir %T/thinlto-archives %T/thinlto-archives/a %T/thinlto-archives/b
----------------
%T is currently deprecated.

You can use `RUN: rm -fr %t && mkdir %t && cd %t` and update the following lines to be relative to `%t`


================
Comment at: lld/test/ELF/lto/thinlto-thinarchivecollision.ll:23
+
+define i32 @main() {
+  call i32 @foo(i32 0)
----------------
Rename to _start to avoid `--entry=main`


================
Comment at: lld/test/ELF/lto/thinlto-thinarchivecollision.ll:28
+}
\ No newline at end of file

----------------
No newline at end of file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79880/new/

https://reviews.llvm.org/D79880





More information about the llvm-commits mailing list