[PATCH] D79885: [FileCheck] Add multiplication support to numerical expressions.

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 10:50:20 PDT 2020


thopre added a comment.

Thanks for this change, multiplication seems like a much needed addition to the numeric expression support indeed.

This changes gives the same priority to the multiplication operator as the addition and subtraction operators. That's counter-intuitive and is sure to bite people later on. The change will also need to update the documentation (llvm/docs/CommandGuide/FileCheck.rst) since it mentions valid operators.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79885/new/

https://reviews.llvm.org/D79885





More information about the llvm-commits mailing list