[PATCH] D79865: [AArch64] Don't promote constants with float ConstantExpr.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 13 10:50:18 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64PromoteConstant.cpp:578
// require some code expansion.
if (!Cst || isa<GlobalValue>(Cst) || isa<ConstantExpr>(Cst))
continue;
----------------
I would rather extend the check here to make it recursive: in addition to restricting ConstantExprs, restrict ConstantAggregates that contain a ConstantExpr or GlobalValue. Or just call Constant::needsRelocation().
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79865/new/
https://reviews.llvm.org/D79865
More information about the llvm-commits
mailing list