[PATCH] D79775: [AsmPrinter] Handle foldable FP constant exprs in initializers.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

needsRelocation() includes both actual references to globals, and arbitrary constantexprs that can't be emitted in any straightforward manner.

Granted, in theory, if a constant expression doesn't refer to any globals, it should theoretically be possible to fold it down to a form the asmprinter can emit: there isn't anything that can vary, so there's only one possible result.  And maybe our constant folder is in fact powerful enough to do that? But I'd rather be conservative, and not assume that.  So I'd rather just restrict the form of the input to the backend: no ConstantExprs, except for a few specific forms of expressions involving pointers which we know the AsmPrinter supports.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79775/new/

https://reviews.llvm.org/D79775