[PATCH] D70107: [VFABI] TargetLibraryInfo mappings in IR.
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 13 10:17:24 PDT 2020
jdoerfert added a comment.
In D70107#2034194 <https://reviews.llvm.org/D70107#2034194>, @fpetrogalli wrote:
> > I don't see anything preventing this from being a function attribute as well.
>
> I appreciate that what I described might be a remote possibility, but if we ever end up having to deal with it, it will be quite hard to fix.
FWIW, I think for generic OpenMP it is needed to annotate the call site. That said, I don't see a fundamental reason one could not annotate the function. So we need the call site attributes and later when we allow them on functions, everything should be in-place. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70107/new/
https://reviews.llvm.org/D70107
More information about the llvm-commits
mailing list